-
Notifications
You must be signed in to change notification settings - Fork 311
ConfigProvider iterates over all sources and reports all non-null val… #9327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ues to ConfigCollector
…ring, ConfigSetting>>
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 44 metrics, 13 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~6a18c79bf7, baseline=1.53.0-SNAPSHOT~f15598ae39
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1051375
Total [baseline] (8.596 s) : 0, 8596277
Agent [candidate] (1.054 s) : 0, 1054419
Total [candidate] (8.626 s) : 0, 8626408
section iast
Agent [baseline] (1.175 s) : 0, 1174599
Total [baseline] (9.3 s) : 0, 9299774
Agent [candidate] (1.186 s) : 0, 1186176
Total [candidate] (9.352 s) : 0, 9351610
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~6a18c79bf7, baseline=1.53.0-SNAPSHOT~f15598ae39
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.494 ms) : 0, 1494
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (735.76 ms) : 0, 735760
BytebuddyAgent [candidate] (739.54 ms) : 0, 739540
GlobalTracer [baseline] (242.812 ms) : 0, 242812
GlobalTracer [candidate] (243.307 ms) : 0, 243307
AppSec [baseline] (29.964 ms) : 0, 29964
AppSec [candidate] (30.265 ms) : 0, 30265
Debugger [baseline] (6.007 ms) : 0, 6007
Debugger [candidate] (6.041 ms) : 0, 6041
Remote Config [baseline] (646.272 µs) : 0, 646
Remote Config [candidate] (699.596 µs) : 0, 700
Telemetry [baseline] (13.643 ms) : 0, 13643
Telemetry [candidate] (12.111 ms) : 0, 12111
section iast
crashtracking [baseline] (1.421 ms) : 0, 1421
crashtracking [candidate] (1.432 ms) : 0, 1432
BytebuddyAgent [baseline] (848.05 ms) : 0, 848050
BytebuddyAgent [candidate] (857.931 ms) : 0, 857931
GlobalTracer [baseline] (232.18 ms) : 0, 232180
GlobalTracer [candidate] (233.092 ms) : 0, 233092
IAST [baseline] (29.152 ms) : 0, 29152
IAST [candidate] (26.957 ms) : 0, 26957
AppSec [baseline] (26.663 ms) : 0, 26663
AppSec [candidate] (29.296 ms) : 0, 29296
Debugger [baseline] (7.42 ms) : 0, 7420
Debugger [candidate] (7.462 ms) : 0, 7462
Remote Config [baseline] (575.651 µs) : 0, 576
Remote Config [candidate] (579.197 µs) : 0, 579
Telemetry [baseline] (8.267 ms) : 0, 8267
Telemetry [candidate] (8.346 ms) : 0, 8346
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~6a18c79bf7, baseline=1.53.0-SNAPSHOT~f15598ae39
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1044526
Total [baseline] (10.689 s) : 0, 10688777
Agent [candidate] (1.05 s) : 0, 1049805
Total [candidate] (10.722 s) : 0, 10722203
section appsec
Agent [baseline] (1.221 s) : 0, 1221479
Total [baseline] (10.77 s) : 0, 10770255
Agent [candidate] (1.225 s) : 0, 1224784
Total [candidate] (10.776 s) : 0, 10776012
section iast
Agent [baseline] (1.186 s) : 0, 1185873
Total [baseline] (10.941 s) : 0, 10940606
Agent [candidate] (1.188 s) : 0, 1187527
Total [candidate] (10.908 s) : 0, 10907579
section profiling
Agent [baseline] (1.2 s) : 0, 1199537
Total [baseline] (10.925 s) : 0, 10925323
Agent [candidate] (1.194 s) : 0, 1194185
Total [candidate] (10.846 s) : 0, 10846238
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~6a18c79bf7, baseline=1.53.0-SNAPSHOT~f15598ae39
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.425 ms) : 0, 1425
crashtracking [candidate] (1.427 ms) : 0, 1427
BytebuddyAgent [baseline] (730.54 ms) : 0, 730540
BytebuddyAgent [candidate] (735.19 ms) : 0, 735190
GlobalTracer [baseline] (241.444 ms) : 0, 241444
GlobalTracer [candidate] (242.518 ms) : 0, 242518
AppSec [baseline] (29.984 ms) : 0, 29984
AppSec [candidate] (30.216 ms) : 0, 30216
Debugger [baseline] (6.061 ms) : 0, 6061
Debugger [candidate] (5.987 ms) : 0, 5987
Remote Config [baseline] (640.496 µs) : 0, 640
Remote Config [candidate] (679.842 µs) : 0, 680
Telemetry [baseline] (13.473 ms) : 0, 13473
Telemetry [candidate] (12.796 ms) : 0, 12796
section appsec
crashtracking [baseline] (1.421 ms) : 0, 1421
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (754.575 ms) : 0, 754575
BytebuddyAgent [candidate] (759.205 ms) : 0, 759205
GlobalTracer [baseline] (235.599 ms) : 0, 235599
GlobalTracer [candidate] (233.928 ms) : 0, 233928
IAST [baseline] (23.413 ms) : 0, 23413
IAST [candidate] (23.552 ms) : 0, 23552
AppSec [baseline] (168.484 ms) : 0, 168484
AppSec [candidate] (170.231 ms) : 0, 170231
Debugger [baseline] (7.249 ms) : 0, 7249
Debugger [candidate] (6.448 ms) : 0, 6448
Remote Config [baseline] (623.578 µs) : 0, 624
Remote Config [candidate] (602.262 µs) : 0, 602
Telemetry [baseline] (9.095 ms) : 0, 9095
Telemetry [candidate] (8.357 ms) : 0, 8357
section iast
crashtracking [baseline] (1.438 ms) : 0, 1438
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (857.242 ms) : 0, 857242
BytebuddyAgent [candidate] (858.636 ms) : 0, 858636
GlobalTracer [baseline] (233.413 ms) : 0, 233413
GlobalTracer [candidate] (233.664 ms) : 0, 233664
IAST [baseline] (29.339 ms) : 0, 29339
IAST [candidate] (26.801 ms) : 0, 26801
AppSec [baseline] (27.768 ms) : 0, 27768
AppSec [candidate] (28.543 ms) : 0, 28543
Debugger [baseline] (6.566 ms) : 0, 6566
Debugger [candidate] (8.279 ms) : 0, 8279
Remote Config [baseline] (585.34 µs) : 0, 585
Remote Config [candidate] (584.434 µs) : 0, 584
Telemetry [baseline] (8.397 ms) : 0, 8397
Telemetry [candidate] (8.346 ms) : 0, 8346
section profiling
crashtracking [baseline] (1.407 ms) : 0, 1407
crashtracking [candidate] (1.4 ms) : 0, 1400
BytebuddyAgent [baseline] (765.352 ms) : 0, 765352
BytebuddyAgent [candidate] (759.914 ms) : 0, 759914
GlobalTracer [baseline] (222.675 ms) : 0, 222675
GlobalTracer [candidate] (221.53 ms) : 0, 221530
AppSec [baseline] (30.008 ms) : 0, 30008
AppSec [candidate] (30.0 ms) : 0, 30000
Debugger [baseline] (6.295 ms) : 0, 6295
Debugger [candidate] (6.247 ms) : 0, 6247
Remote Config [baseline] (704.882 µs) : 0, 705
Remote Config [candidate] (644.413 µs) : 0, 644
Telemetry [baseline] (15.751 ms) : 0, 15751
Telemetry [candidate] (15.973 ms) : 0, 15973
ProfilingAgent [baseline] (107.647 ms) : 0, 107647
ProfilingAgent [candidate] (107.928 ms) : 0, 107928
Profiling [baseline] (108.281 ms) : 0, 108281
Profiling [candidate] (108.524 ms) : 0, 108524
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~6a18c79bf7, baseline=1.53.0-SNAPSHOT~f15598ae39
dateFormat X
axisFormat %s
section baseline
no_agent (4.378 ms) : 4323, 4433
. : milestone, 4378,
iast (9.212 ms) : 9059, 9364
. : milestone, 9212,
iast_FULL (13.877 ms) : 13604, 14149
. : milestone, 13877,
iast_GLOBAL (10.082 ms) : 9904, 10260
. : milestone, 10082,
profiling (8.534 ms) : 8396, 8672
. : milestone, 8534,
tracing (7.756 ms) : 7645, 7867
. : milestone, 7756,
section candidate
no_agent (4.383 ms) : 4334, 4433
. : milestone, 4383,
iast (9.672 ms) : 9512, 9833
. : milestone, 9672,
iast_FULL (13.524 ms) : 13256, 13792
. : milestone, 13524,
iast_GLOBAL (10.162 ms) : 9985, 10339
. : milestone, 10162,
profiling (8.862 ms) : 8720, 9004
. : milestone, 8862,
tracing (7.499 ms) : 7386, 7611
. : milestone, 7499,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~6a18c79bf7, baseline=1.53.0-SNAPSHOT~f15598ae39
dateFormat X
axisFormat %s
section baseline
no_agent (36.586 ms) : 36291, 36880
. : milestone, 36586,
appsec (49.56 ms) : 49117, 50002
. : milestone, 49560,
code_origins (43.104 ms) : 42739, 43470
. : milestone, 43104,
iast (42.316 ms) : 41950, 42683
. : milestone, 42316,
profiling (47.794 ms) : 47329, 48258
. : milestone, 47794,
tracing (44.094 ms) : 43731, 44457
. : milestone, 44094,
section candidate
no_agent (36.539 ms) : 36235, 36843
. : milestone, 36539,
appsec (47.337 ms) : 46932, 47743
. : milestone, 47337,
code_origins (42.952 ms) : 42569, 43335
. : milestone, 42952,
iast (45.91 ms) : 45518, 46302
. : milestone, 45910,
profiling (46.382 ms) : 45968, 46796
. : milestone, 46382,
tracing (44.092 ms) : 43711, 44473
. : milestone, 44092,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~6a18c79bf7, baseline=1.53.0-SNAPSHOT~f15598ae39
dateFormat X
axisFormat %s
section baseline
no_agent (15.65 s) : 15650000, 15650000
. : milestone, 15650000,
appsec (15.007 s) : 15007000, 15007000
. : milestone, 15007000,
iast (18.237 s) : 18237000, 18237000
. : milestone, 18237000,
iast_GLOBAL (17.935 s) : 17935000, 17935000
. : milestone, 17935000,
profiling (15.983 s) : 15983000, 15983000
. : milestone, 15983000,
tracing (14.891 s) : 14891000, 14891000
. : milestone, 14891000,
section candidate
no_agent (14.786 s) : 14786000, 14786000
. : milestone, 14786000,
appsec (14.844 s) : 14844000, 14844000
. : milestone, 14844000,
iast (18.629 s) : 18629000, 18629000
. : milestone, 18629000,
iast_GLOBAL (18.27 s) : 18270000, 18270000
. : milestone, 18270000,
profiling (15.201 s) : 15201000, 15201000
. : milestone, 15201000,
tracing (14.887 s) : 14887000, 14887000
. : milestone, 14887000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~6a18c79bf7, baseline=1.53.0-SNAPSHOT~f15598ae39
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (3.635 ms) : 3420, 3851
. : milestone, 3635,
iast (2.198 ms) : 2136, 2260
. : milestone, 2198,
iast_GLOBAL (2.255 ms) : 2191, 2318
. : milestone, 2255,
profiling (2.026 ms) : 1976, 2076
. : milestone, 2026,
tracing (2.011 ms) : 1963, 2060
. : milestone, 2011,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (3.663 ms) : 3442, 3884
. : milestone, 3663,
iast (2.19 ms) : 2128, 2252
. : milestone, 2190,
iast_GLOBAL (2.233 ms) : 2171, 2295
. : milestone, 2233,
profiling (2.039 ms) : 1989, 2089
. : milestone, 2039,
tracing (2.002 ms) : 1954, 2050
. : milestone, 2002,
|
Code coverage: total 59.74%, base diff 2.47%, patch 85.71% (view details) This comment will be updated automatically if new data arrives.🔗 Commit SHA: 6a18c79 | Docs | Was this helpful? Give us feedback! |
@@ -16,42 +16,52 @@ public class ConfigCollector { | |||
private static final AtomicReferenceFieldUpdater<ConfigCollector, Map> COLLECTED_UPDATER = | |||
AtomicReferenceFieldUpdater.newUpdater(ConfigCollector.class, Map.class, "collected"); | |||
|
|||
private volatile Map<String, ConfigSetting> collected = new ConcurrentHashMap<>(); | |||
private volatile Map<ConfigOrigin, Map<String, ConfigSetting>> collected = | |||
new ConcurrentHashMap<>(); | |||
|
|||
public static ConfigCollector get() { | |||
return INSTANCE; | |||
} | |||
|
|||
public void put(String key, Object value, ConfigOrigin origin) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I mark this one as deprecated?
…dify ConfigProvider methods to report defaults as earlier as possible; nits/cleanup
…ues to ConfigCollector# What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]